Conversation
|
Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8719" |
thewilsonator
force-pushed
the
fix-casts
branch
from
35a95fb to
70890cc
Compare
|
Isn't building with LDC already tested on appveyor? Maybe that setup could be improved to avoid further regressions... |
| else static if (is(T == int)) return cast(T)ld_read(&this); | ||
| else static if (is(T == uint)) return cast(T)ld_read(&this); | ||
| // Account for __c_[u]long | ||
| else static if (__traits(isIntegral,T)) |
There was a problem hiding this comment.
The problem is that on Win32, the host druntime's alias d_int32 = core.stdc.stdint.int32_t = core.stdc.config.cpp_long = __c_long (which is a magic enum). I've had a quick look into the VS 2017 stdint.h, and there int32_t is defined as int, not long, which would fix this as well.
There was a problem hiding this comment.
Closing in favour of dlang/druntime#2302
This is a |
4 participants
No description provided.